feat(GuildMember): Expose serverMute and serverDeaf fields
#10407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r, even if the member is not connected in a voice call.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
RealAlphabet
changed the title
mute and deaf voice status of a member (server mute or deaf).mute and deaf voice status of a member.
almostSouji
requested changes
Jul 24, 2024
There was a problem hiding this comment.
- the docs should state that this is about the server deaf/mute state (as opposed to personal mute/deaf, terminology in-client is "Server Muted"/"Server Deafened")
- the current implementation always shows
falsefor the inner payload of interactions, as those seem to not receive the two fields. potentially making the field nullable could work (same as you need to explicitly fetch a user to receive their public flags)l though this might also be an upstream bug
almostSouji
changed the title
mute and deaf voice status of a member.mute and deaf fields on guild members
…erver mute and deafen state.
RealAlphabet
changed the title
mute and deaf fields on guild membersserverMute and serverDeaf fields on guild members
RealAlphabet
changed the title
serverMute and serverDeaf fields on guild membersserverMute and serverDeaf fields on GuildMember
RealAlphabet
changed the title
serverMute and serverDeaf fields on GuildMemberserverMute and serverDeaf fields
…r on the server and set the default value to ‘null’ if the state is unknown.
I've taken your suggestions on board. Thank you for taking the time to read my PR. I'd be grateful for feedback on the latest changes. I've taken the For your second point, it might definitely be an upstream bug. At least it should be documented by Discord. |
|
Asking for clarification upstream: discord/discord-api-docs#7125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
According to the developer documentation, it is possible to find out whether a member has been muted or deafen by right-clicking. Even if the member is not connected in a voice call.
This is documented by the presence of the two fields in the
GuildMemberstructure.Status and versioning classification: