Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GuildMember): Banners #10384

Merged
merged 6 commits into from
Nov 4, 2024
Merged

feat(GuildMember): Banners #10384

merged 6 commits into from
Nov 4, 2024

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jul 12, 2024

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 10:39am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 10:39am

@Jiralite Jiralite removed this from the discord.js 14.17 milestone Oct 12, 2024
@Jiralite Jiralite marked this pull request as ready for review October 21, 2024 22:44
@Jiralite Jiralite requested a review from a team as a code owner October 21, 2024 22:44
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.49%. Comparing base (a9f629b) to head (45562df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10384       +/-   ##
===========================================
+ Coverage   38.01%   49.49%   +11.47%     
===========================================
  Files         239      228       -11     
  Lines       15471    19510     +4039     
  Branches     1353     1141      -212     
===========================================
+ Hits         5881     9656     +3775     
- Misses       9575     9810      +235     
- Partials       15       44       +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit ef2a687 into main Nov 4, 2024
8 checks passed
@kodiakhq kodiakhq bot deleted the feat/guild-member-banners branch November 4, 2024 10:43
Jiralite added a commit that referenced this pull request Nov 5, 2024
* feat: initial support for guild member banners

* feat: serialise in `toJSON()`

* feat: serialise in `toJSON()`

* docs: lowercase i

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants