Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split licenses #1

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Split licenses #1

merged 3 commits into from
Nov 17, 2021

Conversation

maxdeviant
Copy link
Contributor

This PR splits the LICENSE file out into two files:

  • LICENSE for the gl-matrix license
  • LICENSE_THIRDPARTY for the other licenses

licensee will now correctly detect the contents of the LICENSE file:

λ licensee detect LICENSE
License:        MIT
Matched files:  LICENSE
LICENSE:
  Content hash:  4c2c763d64bbc7ef2e58b0ec6d06d90cee9755c9
  Attribution:   Copyright (c) 2020 Dirk Zimmermann
  Confidence:    100.00%
  Matcher:       Licensee::Matchers::Exact
  License:       MIT

Motivation

gl-matrix is currently in the PureScript package set and will need to have this license issue addressed in order to remain in the package set after the move to the new PureScript registry.

See purescript/registry#250 for more details.

@@ -10,7 +10,7 @@
"test": "echo \"Error: no test specified\" && exit 1"
},
"author": "",
"license": "ISC",
"license": "MIT",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this license identifier to match the LICENSE.

@maxdeviant
Copy link
Contributor Author

@dirkz Thanks for merging! Would you mind publishing a new version of the package? Once published, I can take care of getting it updated in the package set 🙂

@dirkz
Copy link
Owner

dirkz commented Nov 18, 2021

@maxdeviant Thanks for caring. I will publish it in the next few days.

@dirkz
Copy link
Owner

dirkz commented Nov 20, 2021

Published: https://pursuit.purescript.org/packages/purescript-gl-matrix/2.1.0

@maxdeviant Please let me know if there is anything missing from my side and I will provide. I assumed by "publish" you meant a complete pulp publish with an updated version.

@maxdeviant
Copy link
Contributor Author

Published: https://pursuit.purescript.org/packages/purescript-gl-matrix/2.1.0

@maxdeviant Please let me know if there is anything missing from my side and I will provide. I assumed by "publish" you meant a complete pulp publish with an updated version.

Looks like I have everything I need!

And I think only the Git tag is required for the package set, but it doesn't hurt to publish to Pursuit with pulp publish 🙂

Here's the PR that updates gl-matrix in the package set: purescript/package-sets#1037

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants