Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix select2 alpine directive bug when HTMX swaps the same form back into the DOM #35822

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

biyeun
Copy link
Member

@biyeun biyeun commented Feb 21, 2025

Technical Summary

fixes this really delightful error state:
Screenshot 2025-02-20 at 11 39 03 PM

Safety Assurance

Safety story

just fixing an alpine directive that's only being used in the case data cleaning feature right now

Automated test coverage

no

QA Plan

not needed

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@biyeun biyeun added the product/invisible Change has no end-user visible impact label Feb 21, 2025
@biyeun biyeun merged commit 227e9fc into master Feb 21, 2025
13 checks passed
@biyeun biyeun deleted the bmb/dc/alpine-select2-directive branch February 21, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants