Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality for creating new session or resuming/restarting an existing session #35820

Merged
merged 11 commits into from
Feb 21, 2025

Conversation

biyeun
Copy link
Member

@biyeun biyeun commented Feb 21, 2025

Technical Summary

  • adds utility to check if an existing case bulk edit session exists
  • adds utility to check if an existing form bulk edit session exists
  • adds utility to create a new case bulk editing session, including default columns and pinned filters
  • adds utility to restart a case session (delete old session and start a new one)
  • adds tests

new UI additions:
Screenshot 2025-02-21 at 2 52 41 PM
Screenshot 2025-02-21 at 2 52 50 PM

Feature Flag

DATA_CLEANING_CASES

Safety Assurance

Safety story

safe change, does not affect production workflows

Automated test coverage

yes

QA Plan

Not needed

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@biyeun biyeun added the product/invisible Change has no end-user visible impact label Feb 21, 2025
@biyeun biyeun changed the title Backend functionality for creating a BulkEditSession (for cases) + checks Functionality for creating new session or resuming/restarting an existing session Feb 21, 2025
Copy link
Contributor

@nospame nospame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major, but a couple of questions that I would feel more comfortable knowing answers to before approving

Comment on lines +79 to +80
case_session.committed_on = datetime.datetime.now()
case_session.completed_on = datetime.datetime.now()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already know from test_has_no_active_case_session_after_committed that the session won't be active after it's committed, it's not clear what adding a completed_on is doing here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there will never be a state where completed_on is set, but committed_on is null. it's just mimicking that state

Copy link
Contributor

@nospame nospame Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense in trying to mimic a real state, but to me it means this test isn't adding value, since we can't tell whether adding completed_on is doing anything. I don't find it blocking, as it's probably a good test case to consider, but worth thinking through what is the testable distinction between just having committed_on set, and having both committed_on and completed_on set.

@biyeun biyeun merged commit 3f6902f into master Feb 21, 2025
14 checks passed
@biyeun biyeun deleted the bmb/dc/creating-session-backend branch February 21, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants