-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functionality for creating new session or resuming/restarting an existing session #35820
Conversation
includes default columns and pinned filters
BulkEditSession
(for cases) + checks…apline js init within a template
…fcef05ff9551e037e6702468f1c87f)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing major, but a couple of questions that I would feel more comfortable knowing answers to before approving
case_session.committed_on = datetime.datetime.now() | ||
case_session.completed_on = datetime.datetime.now() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we already know from test_has_no_active_case_session_after_committed
that the session won't be active after it's committed, it's not clear what adding a completed_on
is doing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there will never be a state where completed_on
is set, but committed_on
is null. it's just mimicking that state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense in trying to mimic a real state, but to me it means this test isn't adding value, since we can't tell whether adding completed_on
is doing anything. I don't find it blocking, as it's probably a good test case to consider, but worth thinking through what is the testable distinction between just having committed_on
set, and having both committed_on
and completed_on
set.
Technical Summary
new UI additions:


Feature Flag
DATA_CLEANING_CASES
Safety Assurance
Safety story
safe change, does not affect production workflows
Automated test coverage
yes
QA Plan
Not needed
Rollback instructions
Labels & Review