fix value error if there is an issue with initializing domain #35819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biyeun
requested review from
millerdev,
mjriley,
orangejenny,
jingcheng16 and
nospame
dimagimon
added
the
Risk: High
millerdev
previously approved these changes
Feb 21, 2025
millerdev
reviewed
Feb 21, 2025
| @@ -170,7 +170,7 @@ def request_new_domain(request, project_name, is_new_user=True, is_new_sso_user= | |||
| 'first_domain_for_user': is_new_user, | |||
| 'error': str(error), | |||
| }) | |||
| new_domain.delete() | |||
| new_domain.delete(leave_tombstone=True) | |||
There was a problem hiding this comment.
Will this make it impossible to create a domain with the same name in the future? If yes, that seems not great.
There was a problem hiding this comment.
@millerdev it's currently impossible, as the domain is never actually deleted due to the ValueError being thrown. I'm just trying to fix the error here, but I think taking a different approach (full delete and working around the domain deletion checks) can be done later. I don't have time at the moment to dedicate to this.
millerdev
dismissed
their stale review
Thought of a question that suggests maybe there is a better way to do this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
the
deletefunction will always throw aValueError(unless inUNIT_TESTINGmode) due tocommcare-hq/corehq/apps/domain/models.py
Lines 785 to 787 in 12afbba
as a result the following exception (which the UI knows how to handle properly) is never raised
Safety Assurance
Safety story
safe change, also tested locally
Automated test coverage
no
QA Plan
Not needed
Rollback instructions
Labels & Review