Create admin page to check status of emails #35815
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biyeun
reviewed
Feb 21, 2025
| class="form-control" | ||
| placeholder="[email protected]" | ||
| /> | ||
| <input class="btn btn-primary" type="submit" /> |
There was a problem hiding this comment.
i prefer button elements, also better for translating text (which seems to be using the default)
Suggested change
| <input class="btn btn-primary" type="submit" /> | |
| <button class="btn btn-primary" type="submit" >{% trans "Check Status" %}</button> |
orangejenny
reviewed
Feb 21, 2025
| @@ -0,0 +1,39 @@ | |||
| {% extends "hqwebapp/bootstrap3/base_section.html" %} | |||
There was a problem hiding this comment.
B5 please. I think/hope the only things you'll need to change are the button (use btn-outline-primary) and form-inline (doesn't exist in B5).
There was a problem hiding this comment.
On second thought, I can't remember if you can do this without splitting the rest of the app, so maybe not. Adding new B3 pages is unfortunate, though.
orangejenny
reviewed
Feb 21, 2025
| @@ -2617,6 +2617,9 @@ def sidebar_items(self): | |||
| {'title': _('Manage deleted domains'), | |||
| 'url': reverse('tombstone_management'), | |||
| 'icon': 'fa fa-minus-circle'}, | |||
| {'title': _('Check email status'), | |||
| 'url': reverse('email_status'), | |||
| 'icon': 'fa fa-envelope-circle-check'}, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
@AmitPhulera mentioned this idea and I'm reminded of it every time support asks a developer to check if an email is blocked. It would have been nice to reuse the same logic that is used when running the management command
check_bounced_email, which effectively callsBouncedEmail.get_hard_bounced_emails, but there was a lot going on there and I was a bit hesitant to make changes to it since it is used in production code as well.While not the DRYest addition to our codebase, I think it is a net positive as is.
A reasonable next iteration on this would be to allow unblocking an email from this UI, but I figured this is a good enough start and didn't want to sink too much time into it.
Feature Flag
Safety Assurance
Safety story
Just a change to the HQ admin page. The least safe part of this is the idea of taking action based on this information, but I've tried to keep the logic the same for how it does in
BouncedEmail.get_hard_bounced_emails.Automated test coverage
QA Plan
No
Rollback instructions
Labels & Review