Reduce hqImport usage in app_manager #35814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one also uses case_config_ui.js, so $root.trackGoogleEvent is already available.
orangejenny
requested review from
millerdev,
AmitPhulera,
gherceg,
jingcheng16 and
nospame
|
Not linting in this PR. I'll be doing plenty more work in app manager js. |
Needed to do this to fix tests, which use webpack which means all dependencies need to have their dependencies declared. Also updated HTML to ensure all app manager dependencies are loaded in the correct order for the actual rendeering of the page, which does not use webpack. (The non app manager dependencies are all global-ish dependencies that are definitely included before any of the app manager ones.)
orangejenny
force-pushed
the
jls/reduce-hqImport
branch
from
3b4d472 to
4ac4811
Compare
3 tasks
AmitPhulera
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
This is part of the webpack migration for app manager, which will eliminate
hqImport.Review by commit. The "real" changes are minor. I did some prettifying, and I've skimmed those commits to make sure prettify didn't do anything weird.
Safety Assurance
Safety story
Relatively minor changes. Risk is of js errors breaking app manager.
Automated test coverage
not really
QA Plan
Not requesting QA. I've tested these changes locally.
Rollback instructions
Labels & Review