Data Cleaning: add UI placeholders for Filters, Columns, and Edit + some reorg #35805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biyeun
added
the
product/feature-flag
orangejenny
approved these changes
Feb 19, 2025
| @@ -11,6 +11,9 @@ | |||
| <h1 class="fs-3 pe-3 py-3 m-0"> | |||
| {{ current_page.page_name }} | |||
| </h1> | |||
| <div> | |||
| {% include "data_cleaning/partials/button_bar.html" %} | |||
There was a problem hiding this comment.
Nitpick: Is the div necessary? I'd move it inside the include.
There was a problem hiding this comment.
yes, it is for the flexbox styling in the parent div. It's easier to understand the layout if it's there, rather than the button bar.
| @@ -5,7 +5,7 @@ | |||
| from django.views.generic import TemplateView | |||
|
|
|||
| from corehq import toggles | |||
| from corehq.apps.data_cleaning.forms import SelectCaseTypeForm | |||
| from corehq.apps.data_cleaning.forms.setup import SelectCaseTypeForm | |||
There was a problem hiding this comment.
Curious just how many forms you're expecting to create. More than ten? More than twenty? I wasn't thinking of this as a forms-heavy django app, but I don't have a sense of, like, if every filter is going to require its own form.
There was a problem hiding this comment.
quite a few. i want to separate them into columns, filters, etc. also keeping room for Form Data Cleaning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
This adds UI placeholders to the session view for filters, columns, and edit columns
Also some minor reorg and renaming for more forms and form views (with different logical grouping) to come.
Feature Flag
DATA_CLEANING_CASESSafety Assurance
Safety story
Everything here is behind a feature flag. Tests ensure access is correct.
Automated test coverage
Yes
QA Plan
Not needed
Rollback instructions
Labels & Review