Safe mapping #35804
Merged
Safe mapping #35804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a field is in a user's usercase, or custom user data, then use that, otherwise fall back to a CommCareUser property. Only allow safe properties.
dimagimon
added
the
reindex/migration
|
Please note the base branch is currently |
zandre-eng
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Nice catch with this PR. I like the changes, particularly since it now enforces what properties we can pull and makes the mapping process a bit more simple to set up.
If we're no longer going to need a "source" field then I think making the mapping field a dict again sounds like a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
I noticed that with the current way we do mapping, it is possible to expose user secrets. With this change, I realised that maybe we could drop the "source" property in mappings, and got back to using a dictionary. Curious to hear your thoughts.
Feature Flag
KYC_INTEGRATIONS
Safety Assurance
Safety story
Local testing
Automated test coverage
Tests included
QA Plan
No QA planned
Rollback instructions
Labels & Review