Revert "Revert "TableauConnectedApp, TransifexOrganization, and OpenmrsImporter models: AES CBC encryption Migration "" #35802
Conversation
…rsImporter models: AES CBC encryption Migration ""
dimagimon
added
the
reindex/migration
|
@Jtang-1 Just looked at the second commit, which I thought were the only new changes. What was the reason for the revert? I am missing a bit of context. |
…s encrypted so on the migration, it needs to be directly reencrypted
|
@MartinRiese There's two new commits (I just added another). The issue was that the Sravan reverted the previous PR before it was deployed to production (he found the issue upon trying to deploy to staging). |
| else: | ||
| ciphertext = b64_aes_cbc_encrypt(encrypted_secret_value) | ||
| connected_app.encrypted_secret_value = f'${ALGO_AES_CBC}${ciphertext}' | ||
| connected_app.encrypted_secret_value = reencrypt_ecb_to_cbc_mode( |
There was a problem hiding this comment.
Because reencrypt_ecb_to_cbc_mode does the b64 part as well?
There was a problem hiding this comment.
yes but the main fix was that the value is guaranteed to already be encrypted with ecb and without a prefix.
Reverts #35725
This reintroduces the changes in the original PR #35666 and fixes a bug where the
encrypted_secret_valuefield inTableauConnectedApphad an insufficient max_char limit.