Remove firebase-admin dependency #35798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerdev
added
the
product/feature-flag
millerdev
requested review from
a team,
orangejenny,
mkangia,
snopoke and
esoergel
as code owners
ctsims
approved these changes
Feb 18, 2025
ajeety4
approved these changes
Feb 19, 2025
mkangia
reviewed
Feb 19, 2025
| ) | ||
|
|
||
| FCM_NOTIFICATION = StaticToggle( | ||
| 'fcm_notification', | ||
| 'Allows access to FCM Push Notifications', | ||
| 'FCM Push Notifications - no longer functional', |
There was a problem hiding this comment.
Hey @ajeety4
Can you confirm that this would discontinue the feature itself then, FCM notifications?
There was a problem hiding this comment.
The code changes in this PR should simply log an error in case a fcm push notification are attempted via the conditional alerts. I believe follow up work will be require to entirely remove it.
There was a problem hiding this comment.
@ajeety4 Can you help with a ticket for the same? also, no projects are using this?
fyi @shubham1g5 if there is anything to be removed from app side?
There was a problem hiding this comment.
Correction, the code has been asked to kept around for future use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove feature-flagged functionality that depends on firebase-admin to allow it and its sub-dependencies to be removed. This is a minimal PR to make it possible to remove dependencies. More code could and probably should be removed. See #33047 for other things that may also be removed in the future.
Slack discussion.
Feature Flag
Affects
FCM_NOTIFICATIONtoggle, which has been updated with a note that it is no longer functional.Safety Assurance
Safety story
Removes a pre-release feature that is no longer in use.
Automated test coverage
Rollback instructions
If this PR must be reverted the dependencies that are removed will need to be updated to support Python 3.13.