Refactor SubmissionPost.run() #35763
Open
+94
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimagimon
added
the
Risk: High
snopoke
approved these changes
Feb 12, 2025
|
Not sure why my local testing resulted in expected behaviour since the fix seems like a pretty fundamental one. Locally I could submit a case from formplayer and it showed up properly in the case list. (maybe testing it this way isn't sufficient?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Only a refactor - splitting out parts of the code into methods so it reads easier.
Safety Assurance
Safety story
Tested locally. Staging testing also planned.
Automated test coverage
No additional automated tests.
QA Plan
No formal QA planned
Rollback instructions
Labels & Review