Refactor check_build_dependencies #35742
Conversation
| descending=True, | ||
| limit=1, | ||
| skip=1, | ||
| ).first() |
There was a problem hiding this comment.
just confirming that this returns None in case of no previous build? And you tested that I believe for a fresh app then?
There was a problem hiding this comment.
Additionally, can we further improve this by using
reduce=False,
include_docs=False
I believe the key itself would have the ID of the previous build, so you don't need the doc.
Or if works you can wrap the doc returned.
There was a problem hiding this comment.
just confirming that this returns None in case of no previous build?
Yes, it returns None.
Additionally, can we further improve this by using
The include_docs key has a default of False, but not sure about reduce. Will update.
There was a problem hiding this comment.
oh feel free to check what it does, its been a while for me and I remember that these both were to be used together.
There was a problem hiding this comment.
include_docs key has a default of False
Oh cool, does this view then return a key? and not a doc? I was confused by the naming of previous_build_doc
Technical Summary
A refactor based on this comment.
Safety Assurance
Tested locally
Safety story
Small change which only affects how a previous app build is fetched.
QA Plan
No QA needed
Rollback instructions
Labels & Review