AES CBC encryption read and write Clean Up #35681
Merged
+24
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the transition to cbc encryption
…ncrypted with cbc
Jtang-1
changed the title
Jtang-1
requested review from
a team,
AddisonDunn,
minhaminha and
Robert-Costello
and removed request for
a team
minhaminha
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
No user facing effects
Technical Summary
PR1 and PR2 updated models to support reads for both AES ECB and AES CBC encryption while writes only with CBC encryption. This PR cleans up support for reading AES ECB encryption since data has been migrated from ECB to CBC encryption.
Related to USH-5223
Feature Flag
The OpenmrsImporter document is only relevant to openmrs_integration FF
The TableauConnected model is only relevant to embedded_tableau and tableau_user_syncing FF
Safety Assurance
Safety story
Locally tested. This PR only deletes code for a workflow that is no longer applicable since data is no longer ECB encrypted.
Automated test coverage
There exists tests that the encryption and decryption with CBC results in the expected plaintext. Also test that TableauConnectedApp secret value can be encrypted and decrypted.
QA Plan
no QA
Rollback instructions
Labels & Review