3135: Fix tooltip being half hidden on language change hover #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunars97
requested review from
steffenkleinle,
f1sh1918,
LeandraH and
bahaaTuffaha
as code owners
bahaaTuffaha
approved these changes
Mar 5, 2025
f1sh1918
reviewed
Mar 6, 2025
web/src/components/base/Tooltip.tsx
Outdated
| @@ -3,7 +3,7 @@ import { Tooltip as ReactTooltip, ITooltip as ReactTooltipType } from 'react-too | |||
| import styled from 'styled-components' | |||
|
|
|||
| const StyledTooltip = styled(ReactTooltip)` | |||
| z-index: 1; | |||
| z-index: 2; | |||
There was a problem hiding this comment.
i would rather tend to use a higher z-index. We usually use 10x steps in our application.
Our first desktop view relevant component with z-index should be the modal with 100
so you can choose sth in between
Having a higher gap giving the possibility to avoid future issues if we may put sth in between (even if it will likely not happen)
lunars97
force-pushed
the
3135-fix-tooltip-is-cut-on-language-change-hover
branch
from
5d3170a to
5e6f3cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Tooltip is being half hidden when a user hovers over
Change Languagebutton in big width view.Proposed Changes
Side Effects
Testing
Hover over
Change Languagebutton in web and see that the language selector container covers the half of the tooltipResolved Issues
Fixes: #3135