-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3117: Fix search term half-stays on language change #3134
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you! Tested in Firefox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Nicely done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just requesting changes to avoid merging to discuss this. I am not 100% sure but shouldn't the solution be to change the url and keep the search term instead of clearing the search? I'd expect that the reason why users would change the language while searching something would be to get (different) results in another language instead of starting with a clean search? I am not entirely sure though, but I think I would expect that the query is the same after a language change. What do you think (also @f1sh1918 and @LeandraH)?
Edit: Might conflict with #3137.
No, I would expect the query to disappear when changing languages, I would expect to not be using the same words in a different language, especially since German is already handled. Playing around with changing language during a search, I have found both possibilities on other sites. |
Short Description
Currently search term stays in input after language change but the url query gets cleared out.
Proposed Changes
defaultValue
tovalue
in TextInput because defaultValue contains the default value, while value contains the current value after some changes have been made.Side Effects
Testing
Augsburg
Resolved Issues
Fixes: #3117