Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning for upload of daml-script #20704

Draft
wants to merge 1 commit into
base: release/3.2.x
Choose a base branch
from
Draft

Add warning for upload of daml-script #20704

wants to merge 1 commit into from

Conversation

samuel-williams-da
Copy link
Contributor

In 3.2, we will warn on upload of daml-script to canton. In 3.3, we will prevent it entirely.

@samuel-williams-da samuel-williams-da marked this pull request as draft January 29, 2025 15:51
@samuel-williams-da
Copy link
Contributor Author

Discussion with Moritz:
This should be an error first, with an option in the canton config to disable it. We can then remove that option in 3.3.
As well as this, we should error on startup if any daml-script has been uploaded previously. Will need clarification on where this kind of check should live

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samuel-williams-da