API for implicit selfies (bad idea)

[nedtwigg]

I'm pushing this up just to document an idea which turned out to be bad.

For my Selfie usecase, I am often snapshotting two things:

• io.restassured.response.Response which models everything about an HTTP response (content, cookies, headers, etc)
• common.EmailAssert an in-house data structure which models everything about an email (content, subject, etc)

I made a custom Snapshotter<T> for each of them

object TSelfie {
	object Response : Snapshotter<io.restassured.response.Response> { ... }
	object Email : Snapshotter<common.EmailDev> { ... }

but it was a pain to write out expectSelfie(somePage, TSelfie.Response) everywhere, so I tried the approach in this PR.

This turns out to be a bad approach, because a much better approach is

object TSelfie {
	object Response : Snapshotter<io.restassured.response.Response> {
		override fun snapshot(value: io.restassured.response.Response) = ...
		@JvmStatic
		fun expectSelfie(value: io.restassured.response.Response) = Selfie.expectSelfie(value, this)
	}

	object Email : Snapshotter<EmailAssert> {
		override fun snapshot(value: EmailAssert) = ...
		@JvmStatic fun expectSelfie(value: EmailAssert) = Selfie.expectSelfie(value, this)
	}
}

and then in a test I just do:

import static mypkg.TSelfie.Response.expectSelfie
import static mypkg.TSelfie.Email.expectSelfie
import static com.diffplug.selfie.expectSelfie

And I now I get seamless syntax and type-checking without any fanciness from Selfie.