Ruby 3.x, Rails 7, Rails 8, use Appraisals for tests #143
+140
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support Rails 7.2 * Bumped ruby version requirement to 3.0.0 * Rubocop Ruby target as well * remove redundant sort * Update Rakefile * Update test/rails_test.rb * chore: update CI to run on Ruby 3 x Rails 6 & 7 (#3) * chore: add appraisal * update CI to run on ruby/rails matrix * continue on error * no need for dark magic rails test? * Fixed rubocop * don't use deprecated OpenStruct * exclude ruby head / rails 6.1 --------- Co-authored-by: Lud <[email protected]>
* Fix encryption/decryption of arrays * Add subitems to specs * Remove pp * Diff arrays correctly * PR comments * Fix test versions --------- Co-authored-by: Matjaz Kavcic <[email protected]>
* add tests for rails 8 * fix filename * shift ruby versions test, drop rails 7.1 (we got 7.2) * run rubocop against fixed ruby version * drop simple cov, it's crap * we can only test Rails 6 with ruby 3.1 * fix rubocop * fix rails 6 with concurrent ruby * rubocop * Update test.yml * 👮 🤖
marcqualie
approved these changes
Mar 2, 2025
There was a problem hiding this comment.
This is amazing work, thanks for putting all of this together @swiknaba, @mohammed-io, and @MatjazKavcic 🙏🏻 🎉 ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #142
closes #137
closes #122
Thanks to co-authors @mohammed-io & @MatjazKavcic 🙇