feat(DHIS2-18994): support OAuth2 client credentials flow for Route API #19953
+1,022
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cjmamo
commented
Feb 17, 2025
•
cjmamo
commented
- Support OAuth2 client credentials flow for Route API
- Solve nasty security regression which dirties the route entity during decryption causing the clear text secret to be inadvertently persisted. Will attempt to implement a safeguard in a separate PR so that this doesn't happen again.
fix(security): solve regression which dirties the route entity during decryption causing the clear text secret to be inadvertently persisted refactor: replace copy methods in AuthScheme implementations with Lombok builders
jbee
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
I can't really judge the details of the security related code but the rest looks fine. The one comment that is important to me is about the throws Exception in the controller. If possible we want to list concrete exceptions as that is how OpenAPI knows what error responses are possible.
dhis-2/dhis-api/src/test/java/org/hisp/dhis/eventhook/targets/auth/ApiTokenAuthSchemeTest.java
Outdated
Show resolved
Hide resolved
dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/route/RouteService.java
Outdated
Show resolved
Hide resolved
...s/dhis-service-event-hook/src/main/java/org/hisp/dhis/eventhook/handlers/WebhookHandler.java
Show resolved
Hide resolved
dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/RouteController.java
Outdated
Show resolved
Hide resolved
doc: add note about exception handling in WebhookHandler test: replace nulls with stubs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.