feat: implement option set selector in Data dimension modal (DHIS2-17872) #3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3344.data-visualizer.netlify.dhis2.org |
This information is not returned as part of columns/rows/filters but it can be extracted from dataDimensionItems. The optionSetId is also added to the metadata when fetching the dataItems in the Data modal. The rest of the code relies on the presence of optionSetId in metadata in order to enable the option view mode.
5 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-17872
Requires dhis2/analytics#1746
Key features
Description
See description in the analytics PR.
Can be tested against the
https://dev.im.dhis2.org/pdeo-paoinstance as it requires backend support which is not yet merged in master.Run locally with
yarn start --app --proxy=https://dev.im.dhis2.org/pdeo-paoand login usinghttp://localhost:8080as instance URL.TODO
Known issues
optionSetIdin the data returned by the visualization api (solved by extracting the optionSet id fromdataDimensionItems)Screenshots