Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let user pick RP id instead of automatically picking the RP id #2873

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Let user pick RP id instead of automatically picking the RP id #2873

wants to merge 5 commits into from

Conversation

sea-snake
Copy link
Contributor

@sea-snake sea-snake commented Feb 20, 2025 •
edited by github-actions bot
Loading

Let user pick RP id instead of automatically picking the RP id.

Changes

  • Pass optional pickRpId method to connection passkey login so that a screen is rendered where user picks RP id to authenticate with.
  • Keep existing flow logic "as is", the flows of the picked RP id are prioritized within the existing generated flows.
  • Updated e2e tests to automatically pick the first RP id from the list (results in same behavior as previously in e2e)
🟡 Some screens were changed

@sea-snake
Copy link
Contributor Author

image

@sea-snake sea-snake requested a review from lmuntaner February 20, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner Awaiting requested review from lmuntaner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sea-snake