Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option to ignore find in nullish rule #34

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add option to ignore find in nullish rule #34

wants to merge 3 commits into from

Conversation

AntonioVentilii
Copy link
Collaborator

@AntonioVentilii AntonioVentilii commented Nov 16, 2024 •
edited
Loading

Motivation

As suggested by @peterpeterparker in #32 (review) , we add an option to the use-nullish-check rule, to ignore the cases for find function such as arr.find(something) === undefined

@AntonioVentilii AntonioVentilii mentioned this pull request Nov 16, 2024
Merged
peterpeterparker
peterpeterparker approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a bit of documentation for it to the README?

Already approving in case you want to add the doc in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonioVentilii @peterpeterparker