Approval bypass v2 oss #6510
Approval bypass v2 oss #6510
Conversation
prakash100198
requested review from
prakarsh-dt,
vikramdevtron,
nishant-d and
vivek-devtron
as code owners
| IsUserSuperAdmin: isSuperAdmin, | ||
| UserId: userId, | ||
| } | ||
| response := handler.bulkUpdateService.BulkUpdate(script.Spec, userMetadata) |
There was a problem hiding this comment.
can set userMetaData in spec?
There was a problem hiding this comment.
Should we do that? , since userMetadata is not related to bulkUpdatePayload and for checking if a user is exception or not (i.e is allowed to perform action bulk) this userMetadata is a must, and in this way a function expectations will be set that userMetadata is required , so that in future if someone uses this they will pass userMetadata (if that is set in bulk payload then that can be missed )
| UserId: request.UserId, | ||
| } | ||
|
|
||
| response, err := handler.bulkUpdateService.BulkHibernate(r.Context(), request, token, handler.checkAuthForBulkHibernateAndUnhibernate, userMetadata) |
There was a problem hiding this comment.
lets not pass token here, and get token inside through context
| IsUserSuperAdmin: isSuperAdmin, | ||
| UserId: request.UserId, | ||
| } | ||
| response, err := handler.bulkUpdateService.BulkUnHibernate(r.Context(), request, token, handler.checkAuthForBulkHibernateAndUnhibernate, userMetadata) |
|
Description
Fixes #
Checklist:
Does this PR introduce a user-facing change?