#227: Fix paths problem (IDEasy could not set the tool path on first installation) #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
hohwille
requested changes
Feb 26, 2024
There was a problem hiding this comment.
@MustaphaOuchen Thanks for your PR. I will reach out and discuss with you online so we can find the perfect solution together.
hohwille
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
@MustaphaOuchen thanks for the PR & fix. 👍
Ready for merge.
hohwille
changed the title
Pull Request Test Coverage Report for Build 8061828056Details
💛 - Coveralls |
hohwille
added
the
story-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #227
Our problem was that we just fill the paths variable of the SystemPath only during construction with the binary/commandlet locations. I think we have to do it also when tool2pathMap is changed, since tool2pathMap behaves like a "subset" of paths as far as I did understand.
This should fix that on the first start of the application the installed binary could not be found.