Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#31: implement tool commandlet for node package manager #205

Conversation

ndemirca
Copy link
Contributor

@ndemirca ndemirca commented Feb 15, 2024

fixes #31

Unit tests are missing till a test infrastructure will be created

@ndemirca ndemirca marked this pull request as draft February 15, 2024 12:59
@ndemirca ndemirca marked this pull request as ready for review February 15, 2024 13:10
@hohwille hohwille changed the title Feature/31 implement tool commandlet for node package manager #31: implement tool commandlet for node package manager Feb 19, 2024
@hohwille hohwille added this to the release:2024.02.001 milestone Feb 19, 2024
@coveralls
Copy link
Collaborator

coveralls commented Feb 19, 2024

Pull Request Test Coverage Report for Build 8099218662

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 228 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+1.7%) to 58.822%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/jmc/Jmc.java 2 83.33%
com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java 3 88.31%
com/devonfw/tools/ide/tool/aws/Aws.java 3 21.43%
com/devonfw/tools/ide/tool/mvn/Mvn.java 3 14.29%
com/devonfw/tools/ide/tool/LocalToolCommandlet.java 9 74.16%
com/devonfw/tools/ide/tool/ToolCommandlet.java 20 71.69%
com/devonfw/tools/ide/process/ProcessContextImpl.java 26 42.93%
com/devonfw/tools/ide/context/AbstractIdeContext.java 71 66.44%
com/devonfw/tools/ide/io/FileAccessImpl.java 91 55.33%
Totals Coverage Status
Change from base Build 8061873366: 1.7%
Covered Lines: 3999
Relevant Lines: 6538

💛 - Coveralls

Copy link
Contributor

@aBega2000 aBega2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine, except the one change that seems like the reformatting did. Thank you for this PR.

@aBega2000 aBega2000 removed their assignment Feb 19, 2024
MustaphaOuchen and others added 19 commits February 26, 2024 09:09
…olRepoRefactorTestInfra

# Conflicts:
#	cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
…ure/31-Implement-ToolCommandlet-for-Node-Package-Manager
…-Package-Manager

# Conflicts:
#	cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
#	cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java
#	cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java
#	cli/src/main/java/com/devonfw/tools/ide/tool/ToolCommandlet.java
#	cli/src/main/java/com/devonfw/tools/ide/tool/aws/Aws.java
#	cli/src/main/java/com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java
#	cli/src/main/java/com/devonfw/tools/ide/tool/jmc/Jmc.java
#	cli/src/test/java/com/devonfw/tools/ide/commandlet/InstallCommandletTest.java
#	cli/src/test/java/com/devonfw/tools/ide/context/AbstractIdeContextTest.java
#	cli/src/test/java/com/devonfw/tools/ide/context/AbstractIdeTestContext.java
#	cli/src/test/java/com/devonfw/tools/ide/context/IdeTestContext.java
#	cli/src/test/java/com/devonfw/tools/ide/repo/ToolRepositoryMock.java
#	cli/src/test/java/com/devonfw/tools/ide/tool/jmc/JmcTest.java
#	cli/src/test/resources/ide-projects/jmc/project/settings/ide.properties
#	documentation/IDEasy-usage.asciidoc
@ndemirca ndemirca closed this Mar 5, 2024
@ndemirca ndemirca deleted the feature/31-Implement-ToolCommandlet-for-Node-Package-Manager branch March 5, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Implement ToolCommandlet for Node Package Manager
5 participants