#9: background process #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tags
Add parameter for background process and add TODO comments
Also refactored big run method of ProcessContextImpl and wrote tests using mockito
…dProcess # Conflicts: # cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java # cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java # cli/src/main/java/com/devonfw/tools/ide/tool/ToolCommandlet.java # cli/src/main/java/com/devonfw/tools/ide/tool/jmc/Jmc.java
…dProcess # Conflicts: # cli/src/main/java/com/devonfw/tools/ide/tool/jmc/Jmc.java
…hout losing output
MustaphaOuchen
commented
Feb 15, 2024
cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Feb 19, 2024
cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 8063294250Details
💛 - Coveralls |
…aphaOuchen/IDEasy into feature/9-BackgroundProcess
hohwille
requested changes
Feb 23, 2024
There was a problem hiding this comment.
@MustaphaOuchen thanks for your rework. You really mastered this tricky problem and created an excellent solution. Thanks also for adding very detailed and helpful JavaDoc to ProcessMode, etc. 👍
I wanted to resolve all my comments that seemed to be just nice to have so I can even address them after the merge but the last one about Eclipse needs to be addressed before we can merge. Please have a look. If you can resolve all comments even better...
cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/eclipse/Eclipse.java
Outdated
Show resolved
Hide resolved
MustaphaOuchen
commented
Feb 23, 2024
cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java
Outdated
Show resolved
Hide resolved
…rocess # Conflicts: # cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java # cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java
hohwille
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
@MustaphaOuchen thanks for the rework. Great job. Now ready for merge. 👍
hohwille
added
the
story-review
hohwille
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9