Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#103: security warning for CVEs in file tool/edition/security #119

Open
wants to merge 61 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
2237158
#103: security warning for CVEs in file tool/edition/security
MattesMrzik Oct 25, 2023
897b800
promting the user for vulnerabilities and start of Main for OWASP check
MattesMrzik Nov 8, 2023
59f6a1b
merged main into feature 103
MattesMrzik Nov 8, 2023
5f162e2
moved owasp dep from idecli pom to security pom, mor work in Main
MattesMrzik Nov 14, 2023
e5c70e7
#103: url analyzer works and vulnerabilities are retrieved
MattesMrzik Nov 15, 2023
34febf5
#103: Security Entry and determination of version Range for vulnerabi…
MattesMrzik Nov 16, 2023
ae0558b
#103: writing security json file
MattesMrzik Nov 24, 2023
ba87b95
#103: test interaction and getVersionRangeFromInterval
MattesMrzik Dec 5, 2023
ba694ab
#103: refinements
MattesMrzik Dec 6, 2023
81b8586
#103: more refinement
MattesMrzik Dec 14, 2023
9574f8d
#158: VersionRange with open boundaries
MattesMrzik Dec 18, 2023
7e2023e
Merge remote-tracking branch 'upstream/main' into feature/#103-implem…
MattesMrzik Dec 19, 2023
64c8454
Merge remote-tracking branch 'origin/feature/#158-version-range-with-…
MattesMrzik Dec 19, 2023
5518138
#103: removed duplicate VersionRange.equals
MattesMrzik Dec 19, 2023
4fbef6e
#103: versionRange with open interval
MattesMrzik Dec 19, 2023
1b9224b
#103: updated urlSecJsonFile.contains
MattesMrzik Dec 19, 2023
9a86e34
#103: rephrase interaction, mapUtil, LICENCE
MattesMrzik Dec 21, 2023
fe9109f
#103: moved urlSecurityJson to its own class
MattesMrzik Dec 22, 2023
b19b877
#103: fixed write json bug, and more
MattesMrzik Dec 22, 2023
fd64100
#103: some final cleanup
MattesMrzik Jan 2, 2024
312afdd
#103: updated to be in line with #158
MattesMrzik Jan 2, 2024
37122ff
Merge branch 'main' of https://github.com/devonfw/IDEasy into feature…
MattesMrzik Jan 20, 2024
9b28679
#103: fixed small bug due to merged main
MattesMrzik Jan 20, 2024
1389057
#103: fixed bugs
MattesMrzik Jan 20, 2024
98b3da3
#103: fixed bug
MattesMrzik Jan 20, 2024
06cc433
#103: added logging test
MattesMrzik Jan 21, 2024
80ab231
#103: refactored code
MattesMrzik Jan 21, 2024
a26df56
103: first half of team review
MattesMrzik Jan 21, 2024
dbee293
#103: more change requests from team review and bug fix
MattesMrzik Jan 21, 2024
ea1bb26
Update cli/src/main/java/com/devonfw/tools/ide/tool/ToolCommandlet.java
MattesMrzik Jan 22, 2024
b02bfcf
#103: checkpoint to not accidentally lose progress
MattesMrzik Jan 23, 2024
fb6b842
Merge branch 'feature/#103-implement-version-security-checks' of http…
MattesMrzik Jan 23, 2024
0c54094
#103: fixed intellij updater test
MattesMrzik Jan 23, 2024
55f139c
#103: done with change requests
MattesMrzik Jan 24, 2024
d69bea7
Merge branch 'main' of https://www.github.com/devonfw/IDEasy into fea…
MattesMrzik Jan 25, 2024
f34fc22
Update security/src/main/java/com/devonfw/tools/security/BuildSecurit…
MattesMrzik Jan 25, 2024
1c66c77
#103: small fix
MattesMrzik Jan 25, 2024
c78aad4
Merge branch 'feature/#103-implement-version-security-checks' of http…
MattesMrzik Jan 25, 2024
6a20d3c
#103: added tests
MattesMrzik Jan 25, 2024
cbe086d
#103: test for UrlSecurityJson
MattesMrzik Jan 25, 2024
20fecc3
#103: last small changes
MattesMrzik Jan 26, 2024
47ae5b7
Merge branch 'main' into feature/#103-implement-version-security-checks
jan-vcapgemini Feb 19, 2024
ae52292
#103: code reformat & cleanup
jan-vcapgemini Feb 19, 2024
f66c7ea
#103: implemented requested changes
jan-vcapgemini Feb 19, 2024
7628cc9
#103: applied reformat
jan-vcapgemini Feb 19, 2024
db6e276
#103: implemented requested changes
jan-vcapgemini Feb 19, 2024
6da9066
Merge branch 'main' into feature/#103-implement-version-security-checks
jan-vcapgemini Feb 22, 2024
2862e6b
#103: fixed merge issues
jan-vcapgemini Feb 22, 2024
be3ec96
#103: some fixes
jan-vcapgemini Feb 22, 2024
097bbdc
Merge branch 'main' into feature/#103-implement-version-security-checks
jan-vcapgemini Feb 23, 2024
a7d686c
#103: implemented requested changes
jan-vcapgemini Feb 23, 2024
a299504
#103: implemented requested changes
jan-vcapgemini Feb 23, 2024
0f3596f
#103: implemented requested changes
jan-vcapgemini Feb 23, 2024
30d5bf2
Merge branch 'main' into feature/#103-implement-version-security-checks
jan-vcapgemini Feb 26, 2024
69e1fdd
#103: fixed intellij and vscode
jan-vcapgemini Feb 29, 2024
4d6766c
#103: fixed NPEs and other issues
jan-vcapgemini Feb 29, 2024
f162e09
Merge branch 'main' into feature/#103-implement-version-security-checks
jan-vcapgemini Feb 29, 2024
3834ce8
Merge branch 'main' into feature/#103-implement-version-security-checks
jan-vcapgemini Mar 28, 2024
ba4bc07
#103 fixed tests
jan-vcapgemini Apr 2, 2024
d794e67
Merge branch 'main' into feature/#103-implement-version-security-checks
jan-vcapgemini Apr 2, 2024
998387d
#103 implemented requested changes
jan-vcapgemini Apr 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions cli/src/main/java/com/devonfw/tools/ide/tool/ToolCommandlet.java
Original file line number Diff line number Diff line change
@@ -21,6 +21,7 @@
import com.devonfw.tools.ide.process.ProcessErrorHandling;
import com.devonfw.tools.ide.property.StringListProperty;
import com.devonfw.tools.ide.repo.ToolRepository;
import com.devonfw.tools.ide.url.model.file.UrlSecurityFile;
import com.devonfw.tools.ide.util.FilenameUtil;
import com.devonfw.tools.ide.version.VersionIdentifier;

@@ -260,6 +261,15 @@ protected boolean doInstall(boolean silent) {

// check if we already have this version installed (linked) locally in IDE_HOME/software
VersionIdentifier installedVersion = getInstalledVersion();

UrlSecurityFile securityFile = this.context.getUrls().getEdition(this.tool, this.getEdition()).getSecurityFile();
// I do not want to use the installed version here, as I want to warn the user whether the tool is installed or not.
VersionIdentifier currentVersion = this.context.getUrls().getVersion(this.tool, this.getEdition(), configuredVersion);
if (securityFile.contains(currentVersion)) {
this.context.warning("Version {} of tool {} is known to have security issues!", currentVersion,
getToolWithEdition());
}

VersionIdentifier resolvedVersion = installation.resolvedVersion();
if (isInstalledVersion(resolvedVersion, installedVersion, silent)) {
return false;