Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump the Queue- review comments fixed #103

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

dixyushi
Copy link
Contributor

@dixyushi dixyushi commented May 6, 2021

Tested and fixed the review comments in Jump the Queue tutorial.

@dixyushi dixyushi requested a review from isandesh1986 May 6, 2021 07:52
@github-actions
Copy link

github-actions bot commented May 6, 2021

@github-actions
Copy link

github-actions bot commented May 6, 2021

Thanks for submitting your work on a (new) tutorial!

Some suggestions, which might help:

  • Title: Focus on what you want to train in a few words. Don't be too generic
  • Tutorial:
    • Address the user directly.
    • Explain why the steps are necessary.
    • Explain what are the results and why are they necessary for your next step.
    • Forward the user to more elaborate documentation on the website (deep links) for further reading

Also please find further help for creating tutorials here or more help regarding the tutorial syntax here.

You can view the generated tutorials of this PR here in a few minutes. You just have to wait for the run of the deployment action to finish.

When you think you are done writing the tutorial try the tutorial on the deveplopment area and check if you explained every step in a way someone who is trying to learn what you are teaching can understand. Ideally ask someone to have a look on what you have done and have that part double checked because this is very important.

@dixyushi dixyushi marked this pull request as draft May 6, 2021 07:52
isandesh1986
isandesh1986 previously approved these changes May 6, 2021
@dixyushi dixyushi marked this pull request as ready for review May 7, 2021 04:49
@dixyushi dixyushi requested a review from isandesh1986 May 7, 2021 05:12
@SchettlerKoehler
Copy link
Collaborator

What is the state of this PR?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of your course is already used on a playbook. Please change the name.

mustafaokyay
mustafaokyay previously approved these changes Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants