feature: new tables on Search Analytics #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaraVieira
requested review from
drew-harris and
skeptrunedev
and removed request for
drew-harris
drew-harris
reviewed
Sep 16, 2024
| @@ -36,7 +37,11 @@ export const TanStackTable = (props: TableProps) => { | |||
| <tr> | |||
| <For each={headerGroup.headers}> | |||
| {(header) => ( | |||
| <th class="sticky top-0 z-10 border-b border-neutral-300 bg-white bg-opacity-75 py-3.5 pl-4 pr-3 text-left text-sm font-semibold text-neutral-900 backdrop-blur backdrop-filter sm:pl-6 lg:pl-8"> | |||
| <th | |||
There was a problem hiding this comment.
I would use the cn utility or the classList attribute for conditional styles instead of interpolating. Its more consistent with the ordering and application of styles
There was a problem hiding this comment.
Oh true we have that, I forgot. On it
drew-harris
reviewed
Sep 16, 2024
| @@ -15,6 +15,7 @@ export type SortableColumnDef<TValue> = ColumnDef<any, TValue> & { | |||
| type TableProps = { | |||
There was a problem hiding this comment.
Would be nice to add a class prop that gets appended to the container styles so that its more versatile
skeptrunedev
changed the title
skeptrunedev
force-pushed
the
feat_new_tables_search
branch
from
dd3a5c6
to
17105a7
Compare
skeptrunedev
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
