Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat - new search react component #2261

Merged
merged 6 commits into from
Aug 31, 2024
Merged

Conversation

SaraVieira
Copy link
Contributor

@SaraVieira SaraVieira commented Aug 27, 2024

  • Search component
  • Modal Search Component
  • Add web components support

Example: https://trieve-react-search.surge.sh/

Copy link
Contributor

@skeptrunedev skeptrunedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Major nit I have is that it should show the title then, subsequently, the highlights below it. If the title is in the chunk_html then it should be removed as well. I would look for children matching the title text and remove those then mark the title as highlighted. But also maybe don't remove? I'm not sure, should study how Mintlify does it.

@skeptrunedev
Copy link
Contributor

I think we should highly prioritize setting up chat for this as well

@SaraVieira
Copy link
Contributor Author

The highlights should be much better now and will work on chat tomorrow

Copy link
Contributor

@skeptrunedev skeptrunedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Definitely a fully functional component for search and I'm hype about it. Arrows and everything work and the display looks great.

Sorry for being pedantic with the commit history, but I'm nervous our total commit count is getting too large and makes us seem sus lol. Hype about this!

@skeptrunedev skeptrunedev merged commit 7b9aa38 into main Aug 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants