Adding support for RedHat Jboss EAP 8.0 #430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-valdron
requested changes
Jun 21, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ehsavoie The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Emmanuel Hugonnet <[email protected]>
thepetk
reviewed
Jun 25, 2024
There was a problem hiding this comment.
@ehsavoie Tried to test the PR locally with odo3, but I'm getting the following error:
Failed to pull image "registry.redhat.io/devspaces/udi-rhel8:3.11-14": rpc error: code = Unknown desc = Error response from daemon: Head "https://registry.redhat.io/v2/devspaces/udi-rhel8/manifests/3.11-14": unauthorized: Please login to the Red Hat Registry using your Customer Portal credentials. Further instructions can be found here: https://access.redhat.com/RegistryAuthentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
Which issue(s) this PR fixes:
Link to github issue(s)
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: