Set namespace for helm chart template specs #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Valdron <[email protected]>
openshift-ci
bot
added
the
approved
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage 27.27% 27.27%
=======================================
Files 7 7
Lines 2009 2009
=======================================
Hits 548 548
Misses 1414 1414
Partials 47 47 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify the area for this PR
helm chart
What does does this PR do / why we need it:
Adds
metadata.namespacefield to all helm chart template specs:configmap.yamldeployment.yamlingress.yamlpvc.yamlroute.yamlservice.yamlThis is part of keeping deployments consistent with specs defined under devfile/registry-operator.
Which issue(s) this PR fixes:
Fixes #?
fixes devfile/api#1432
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
Deploy with helm chart under any environment to test this out. Deploy with operator to compare with devfile registry deployments via the devfile/registry-operator.