-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency check for current child samples #1142
Comments
Targeting this issue for next sprint to focus on higher prior items. |
For the parent stack dependency tree we can use a Proposed parents file: parents:
stack1_name:
children:
- name: child1_name
- name: child2_name
version: 1.0.2
stack2_name:
version: 1.1.0
children:
- name: child3_name |
How quick is the script to build the parent.yaml? If the generation of the script is quick, can we just generate it on the fly instead of storing it as part of the repo? The issue with running nightly is what if the PR introduces a new dependency? Then the PR build may not be able to trigger the dependent child test run. |
@elsony I'll need to look into building the file using multiple versions but yeah this makes for sense on the fly over nightly due to it building fast enough and getting the recent sample changes in real-time. I could still build this yaml in the check script then passing it into the Go test suite to be worked on. |
Revised parents yaml based on multiple parent versions: parents:
- name: stack1_name
children:
- name: child1_name
- name: child2_name
version: 1.0.2
- name: stack2_name
version: 1.1.0
children:
- name: child3_name
- name: stack2_name
version: 1.2.0
children:
- name: child3_name
- name: child4_name |
Have created test suite for validating child samples, continuing to work out errors and fit multi versions for both stacks and samples. Targeting next sprint to accomplish this. |
Additional test suite has been scrapped for reuse of existing test suite for stack validation, some stack testing cannot be reused and is omitted from these additions. |
Ready for review: devfile/registry#195 |
Investigating a problem with the validate devfile schema test suite: devfile/registry#195 (comment) |
Continuing in Sprint 245 due to vacation leave. |
Moved item to 245 as requested |
Change in priority this sprint requires my focus on other issues at this time. |
Repriorizing this issue to be planned for resuming in upcoming sprint due to issues caused by recent changes to parent stacks, increasing priority to critical. |
Failures of |
PR ready for review: devfile/registry#397 |
Which area/kind this issue is related to?
/area ci
/area registry
Issue Description
In order to ensure our current child samples remain compatible with changes to their parent stacks, a dependency check on these samples will be necessary to prevent breaking changes from being introduced to the parents. This dependency check should be run on all PRs made to the community registry repository.
We need to:
The auto-generated dependency tree and inclusion of additional child stacks/samples are planned in the upcoming #1060 changes.
The text was updated successfully, but these errors were encountered: