Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency check to make sure child devfiles are being tested when parent stack has been changed #1060

Closed
elsony opened this issue Mar 17, 2023 · 5 comments
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days.

Comments

@elsony
Copy link
Contributor

elsony commented Mar 17, 2023

Which area/kind this issue is related to?

/area registry

Issue Description

The current PR tests in the devfile registry only test for stacks/samples that have been changed. However, if there are other stacks/samples referring to the changed stacks as parents, the child stacks/samples test does not run. There is a risk in case the parent stack change may break the depending stacks/samples.

We need to:

  1. Set up a dependency tree (auto-generated based on the current registry contents) so that we can easily find out the depending stacks/samples of a given stack.
  2. Triggers the child stacks/samples test as part of the PR tests of the parent stacks

Target Odo version

N/A

@openshift-ci openshift-ci bot added the area/registry Devfile registry for stacks and infrastructure label Mar 17, 2023
@michael-valdron michael-valdron moved this to Backlog in Devfile Project May 19, 2023
@michael-valdron michael-valdron self-assigned this May 19, 2023
@thepetk thepetk moved this from Backlog to To Do 📝 in Devfile Project May 29, 2023
@kim-tsao kim-tsao moved this from To Do 📝 to Backlog in Devfile Project Jun 21, 2023
@michael-valdron
Copy link
Member

The initial dependency check work for current child samples is now being tracked under #1142, this issue will now track the continuation of that work to expand to considering additional child stacks/samples not yet part of the community registry.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Sep 20, 2023
@github-actions github-actions bot removed the lifecycle/stale Stale items. These items have not been updated for 90 days. label Sep 21, 2023
@michael-valdron michael-valdron moved this from Backlog to Refinement in Devfile Project Nov 28, 2023
@Jdubrick Jdubrick moved this from Refinement to Backlog in Devfile Project Jan 18, 2024
@Jdubrick
Copy link
Contributor

Depends on completion of #1142

@michael-valdron
Copy link
Member

Depends on completion of #1142

This issue is unblocked now.

Copy link

github-actions bot commented Sep 9, 2024

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Sep 9, 2024
@github-actions github-actions bot added the lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. label Nov 9, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done ✅ in Devfile Project Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days.
Projects
Status: Done ✅
Development

No branches or pull requests

3 participants