Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial auth implementation #30

Merged
merged 10 commits into from
Apr 1, 2025
Merged

Initial auth implementation #30

merged 10 commits into from
Apr 1, 2025

Conversation

danielfdsilva
Copy link
Member

@danielfdsilva danielfdsilva commented Mar 17, 2025

Contributes to

@j08lue still needs #29 but we can merge and handle it later

Copy link
Member

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this implementation taking shape. I have a clarifying question before, please see comments below.

@danielfdsilva
Copy link
Member Author

to test:

## Keycloak auth variables
REACT_APP_KEYCLOAK_URL=https://keycloak.delta-backend.xyz
REACT_APP_KEYCLOAK_CLIENT_ID=stac
REACT_APP_KEYCLOAK_REALM=veda

@danielfdsilva danielfdsilva requested a review from j08lue March 19, 2025 18:25
@j08lue
Copy link
Member

j08lue commented Mar 24, 2025

When I run this locally against VEDA KeyCloak, I get

image

URL is https://keycloak.delta-backend.xyz/realms/veda/protocol/openid-connect/auth?client_id=stac&redirect_uri=http%3A%2F%2Flocalhost%3A9000%2F&<some more stuff>

I guess it does not like the redirect_uri for localhost or so.

Copy link
Member

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, after adding localhost as redirect URI in KeyCloak again, it worked.

image

Just the "Profile" link does not seem to do anything. Should we remove that?

image

And where does that blue button / avatar come from? Could that be replaced with either an avatar or something else that matches the design? And do we have designs for the button when no user is logged in? It currently shows this grey user icon, which to me lacks to signify that I am not logged in and could log in here.

image

@danielfdsilva
Copy link
Member Author

@j08lue Profile is supposed to take the user to some form of account management, to update name, password etc... Not sure what the url is but we should figure it out.
The blue icon is from gravatar. Basically if there's an image associated with the user email that is shown, otherwise it shows that logo. I'll change the default to something like user initials. If keycloak's user management ends up having user thumbs we can use that.

Agree with the logged out state. @ricardoduplos Do you have a suggestion?

@j08lue
Copy link
Member

j08lue commented Mar 24, 2025

Thanks for clarifying!

Profile is supposed to take the user to some form of account management

I am not sure any of our platforms provides a profile management UI for users. If they did, then it would probably live somewhere separate. So I think it would be fair to omit this link from STAC Manager and leave it to the platform to provide a user with a link to that kind of interface elsewhere, if they have one.

@danielfdsilva danielfdsilva requested a review from j08lue March 26, 2025 15:25
@danielfdsilva danielfdsilva merged commit eb74d32 into main Apr 1, 2025
@danielfdsilva danielfdsilva deleted the feature/auth branch April 1, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants