-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial auth implementation #30
Conversation
9c26b78
to
25f0015
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this implementation taking shape. I have a clarifying question before, please see comments below.
25f0015
to
bc6b2e3
Compare
to test:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, after adding localhost as redirect URI in KeyCloak again, it worked.
Just the "Profile" link does not seem to do anything. Should we remove that?
And where does that blue button / avatar come from? Could that be replaced with either an avatar or something else that matches the design? And do we have designs for the button when no user is logged in? It currently shows this grey user icon, which to me lacks to signify that I am not logged in and could log in here.
@j08lue Profile is supposed to take the user to some form of account management, to update name, password etc... Not sure what the url is but we should figure it out. Agree with the logged out state. @ricardoduplos Do you have a suggestion? |
Thanks for clarifying!
I am not sure any of our platforms provides a profile management UI for users. If they did, then it would probably live somewhere separate. So I think it would be fair to omit this link from STAC Manager and leave it to the platform to provide a user with a link to that kind of interface elsewhere, if they have one. |
Contributes to
@j08lue still needs #29 but we can merge and handle it later