Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix surge deploy example #96

Merged
merged 1 commit into from
May 20, 2021
Merged

Fix surge deploy example #96

merged 1 commit into from
May 20, 2021

Conversation

vgeorge
Copy link
Member

@vgeorge vgeorge commented May 19, 2021

The surge deploy example using Github Actions raises a permission error on npm install -g surge, it seems not possible to install modules globally this way. This PR fix this issue by using a local version of surge module. It was tested in bri-web.

@vgeorge vgeorge requested a review from danielfdsilva May 19, 2021 17:35
@vgeorge
Copy link
Member Author

vgeorge commented May 20, 2021

Just a note on the permission error, @AliceR pointed out it was happening because the deploy task didn't had a setup-node step. We could add it back, but the solution on this PR is better because it uses a surge client that is already available in the cache and should complete in less time.

@vgeorge vgeorge merged commit f4663f3 into main May 20, 2021
@vgeorge vgeorge deleted the fix/surge-deploy-example branch May 20, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants