Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed all issues #76

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/index.html
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
<nav class="top">
<div class="bar blue card left-align large">
<a
class="bar-item button hide-medium hide-large right padding-large hover-white large blue"
class="bar-item button hide-large right padding-large hover-white large blue"
href="javascript:void(0);"
id="hamburger-button"
onclick="toggleNav()"
@@ -24,14 +24,14 @@
></a>
<!-- TODO: Fix Issue, Desktop Nav Is Visible on Mobile -->
<a id="nav-logo" class="bar-item button padding-large white">JobSimulator.Dev</a>
<a id="nav-challenges" class="bar-item button padding-large hover-white">Browse Challenges</a>
<a id="nav-signup" class="bar-item button padding-large hover-white">Sign Up</a>
<a id="nav-challenges" href="#challenges" class="bar-item button hide-medium hide-small padding-large hover-white">Browse Challenges</a>
<a id="nav-signup" href="#signup" class="bar-item button hide-medium hide-small padding-large hover-white">Sign Up</a>
</div>

<!-- Navbar on small screens -->
<div id="mobile-nav" class="bar-block white hide hide-large hide-medium large">
<a id="mobile-nav-challenges" class="bar-item button padding-large">Browse Challenges</a>
<a id="mobile-nav-signup" class="bar-item button padding-large">Sign Up</a>
<div id="mobile-nav" class="bar-block white hide hide-large large">
<a id="mobile-nav-challenges" href="#challenges" class="bar-item button padding-large">Browse Challenges</a>
<a id="mobile-nav-signup" href="#signup" class="bar-item button padding-large">Sign Up</a>
</div>
</nav>

37 changes: 30 additions & 7 deletions src/script.js
Original file line number Diff line number Diff line change
@@ -19,18 +19,41 @@ let resetMessage = () => {
document.getElementById("empty-error-message").hidden = true;
};

addEventListener("submit", (event) => {
event.preventDefault();
resetMessage();
let repeat_email = "";

let email = document.getElementById("email").value;
addEventListener(
"submit",
(event) => {
event.preventDefault();
resetMessage();

// TODO: Show Correct Status Messages on Signup Form
// 1. successful signup
let email = document.getElementById("email").value;

// TODO: Show Correct Status Messages on Signup Form
// 1. successful signup

if (email.length < 1) {
renderEmailEmptyError();
return;
}
if (email === repeat_email) {
renderEmailTakenError();
return;
}
for (let item of usersTable) {
if (email === item.username) {
renderEmailTakenError();
return;
}
}
renderSuccess();

repeat_email = email;
}
// 2. empty email
// 3. taken email
// 4. repeat email
});
);

let toggleNav = () => {
var nav = document.getElementById("mobile-nav");
3 changes: 2 additions & 1 deletion src/styles.css
Original file line number Diff line number Diff line change
@@ -670,6 +670,7 @@ form > span {
#jumbo-image {
max-height: 20rem;
/* TODO: Invert banner colors using CSS */
filter: invert(85%);
}

@media (max-width: 600px) {
@@ -877,7 +878,7 @@ form > span {
#challenge-grid {
display: grid;
/* TODO: Fix Issue, Tiles Need to be 2x2 Grid. Change only grid-template-columns */
grid-template-columns: none;
grid-template-columns: 1fr 1fr;
grid-auto-rows: 10rem;
gap: 1rem;
padding-top: 2rem;