Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom screens support RELEASE #1012

Merged
merged 25 commits into from
Feb 11, 2025
Merged

feat: Custom screens support RELEASE #1012

merged 25 commits into from
Feb 11, 2025

Conversation

nirgur
Copy link
Collaborator

@nirgur nirgur commented Feb 9, 2025

This PR brings custom screens support to the flows SDKs
It introduce a new function onScreenUpdate (more details in the readme)

It's dependent on this PR to be deployed so we will get also the first screen name

Related Issues

Related https://github.com/descope/etc/issues/570

Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
access-key-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 4:06pm
audit-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 4:06pm
role-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 4:06pm
user-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 4:06pm
user-profile-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 4:06pm

Copy link

nx-cloud bot commented Feb 9, 2025

View your CI Pipeline Execution ↗ for commit 6ff800a.

Command Status Duration Result
nx affected --target test:e2e ✅ Succeeded 4m 46s View ↗
nx affected --target test ✅ Succeeded 3m 26s View ↗
nx affected --target lint --fix=true ✅ Succeeded 1m View ↗
nx affected --target build ✅ Succeeded 2m 49s View ↗
nx affected --target licenseCheck ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-11 16:16:04 UTC

Copy link
Member

@asafshen asafshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

might be out of scope for this, but it would be valueable to have examples for screen states that does

  • passwords (just a regular form)
  • polling (enchanted link)
  • webauthn
  • totp

packages/libs/sdk-helpers/src/state.ts Show resolved Hide resolved
packages/sdks/react-sdk/src/types.ts Show resolved Hide resolved
packages/sdks/web-component/src/lib/types.ts Show resolved Hide resolved
packages/sdks/web-component/src/lib/types.ts Show resolved Hide resolved
@nirgur
Copy link
Collaborator Author

nirgur commented Feb 11, 2025

looks good

might be out of scope for this, but it would be valueable to have examples for screen states that does

  • passwords (just a regular form)
  • polling (enchanted link)
  • webauthn
  • totp

What do you mean?
I don't think we are returning the passwords in clear text
regarding the rest, how it can be vulnerable? can you please explain

@asafshen
Copy link
Member

looks good
might be out of scope for this, but it would be valueable to have examples for screen states that does

  • passwords (just a regular form)
  • polling (enchanted link)
  • webauthn
  • totp

What do you mean? I don't think we are returning the passwords in clear text regarding the rest, how it can be vulnerable? can you please explain

I don't think anything is vulnerable - I'm just saying its not trivial to know how you run it, and it will be nice to have examples, especially when screens does "complex" stuff like polling, webauthn, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants