-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Custom screens support RELEASE #1012
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit 6ff800a.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
might be out of scope for this, but it would be valueable to have examples for screen states that does
- passwords (just a regular form)
- polling (enchanted link)
- webauthn
- totp
What do you mean? |
I don't think anything is vulnerable - I'm just saying its not trivial to know how you run it, and it will be nice to have examples, especially when screens does "complex" stuff like polling, webauthn, etc |
This PR brings custom screens support to the flows SDKs
It introduce a new function
onScreenUpdate
(more details in the readme)It's dependent on this PR to be deployed so we will get also the first screen name
Related Issues
Related https://github.com/descope/etc/issues/570