feature(uiComponents) ergonode#70 Code improvement

derpdead · Jul 22, 2019 · da87b32 · da87b32
1 parent 2a51329
commit da87b32
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 15 deletions.
diff --git a/components/Inputs/Date/DatePicker.vue b/components/Inputs/Date/DatePicker.vue
@@ -122,11 +122,13 @@ export default {
         onPreviousDate() {
             switch (this.selectedCalendarType) {
             case CalendarType.DAY: {
-                const { month, year } = getPreviousMonth(this.month, this.year);
+                const {
+                    month: previousMonth, year: previousYear,
+                } = getPreviousMonth(this.month, this.year);
 
-                this.month = month;
-                this.year = year;
-                this.calendarHeader = getHeaderForCalendarDaysType(month, year);
+                this.month = previousMonth;
+                this.year = previousYear;
+                this.calendarHeader = getHeaderForCalendarDaysType(previousMonth, previousYear);
 
                 break;
             }

diff --git a/components/Inputs/Date/DatePickerCalendarContent.vue b/components/Inputs/Date/DatePickerCalendarContent.vue
@@ -110,8 +110,6 @@ export default {
                 if (date.getFullYear() === this.year) {
                     return this.months[date.getMonth()];
                 }
-
-                return '';
             }
 
             return '';

diff --git a/components/Inputs/Date/DatePickerMonthDays.vue b/components/Inputs/Date/DatePickerMonthDays.vue
@@ -44,12 +44,6 @@ export default {
         };
     },
     methods: {
-        onMouseOver() {
-
-        },
-        onMouseOut() {
-
-        },
         onSelectDate(date) {
             this.$emit('select', { ...date });
         },

diff --git a/components/Inputs/Date/DateRangePicker.vue b/components/Inputs/Date/DateRangePicker.vue
@@ -119,10 +119,12 @@ export default {
             return Object.keys(CALENDAR_MONTHS)[Math.max(0, Math.min(month - 1, 11))];
         },
         previousMonth() {
-            const { month, year } = getPreviousMonth(this.lowerBoundMonth, this.lowerBoundYear);
+            const {
+                month: previousMonth, year: previousYear,
+            } = getPreviousMonth(this.lowerBoundMonth, this.lowerBoundYear);
 
-            this.lowerBoundMonth = month;
-            this.lowerBoundYear = year;
+            this.lowerBoundMonth = previousMonth;
+            this.lowerBoundYear = previousYear;
             this.upperBoundMonth = this.upperBoundMonth > 1
                 ? this.upperBoundMonth - 1
                 : 12;