tv bump 4 (#3)

* fix lat test

* apply cs

* separate

.github/FUNDING.yml

@@ -0,0 +1,3 @@
+# These are supported funding model platforms
+github: tomasvotruba
+custom: https://www.paypal.me/rectorphp

.github/workflows/code_analysis.yml

@@ -1,29 +1,46 @@
 name: Code Analysis
 
 on:
-    push: null
     pull_request: null
+    push:
+        branches:
+            - main
 
 jobs:
-    build:
+    code_analysis:
+        strategy:
+            fail-fast: false
+            matrix:
+                actions:
+                    -
+                        name: 'Composer Validate'
+                        run: composer validate --ansi
+
+                    -
+                        name: 'PHPStan'
+                        run: composer phpstan --ansi
+
+                    -
+                        name: 'Coding Standard'
+                        run: composer fix-cs --ansi
+
+                    -
+                        name: 'Tests'
+                        run: vendor/bin/phpunit
+
+        name: ${{ matrix.actions.name }}
         runs-on: ubuntu-latest
 
         steps:
-          - uses: actions/checkout@v3
+            -   uses: actions/checkout@v3
 
-          - name: Setup PHP
-            uses: shivammathur/setup-php@v2
-            with:
-              php-version: 8.1
+            # see https://github.com/shivammathur/setup-php
+            -   uses: shivammathur/setup-php@v2
+                with:
+                    php-version: 8.2
+                    coverage: none
 
-          - name: Validate composer
-            run: composer validate
+            # composer install cache - https://github.com/ramsey/composer-install
+            -   uses: "ramsey/composer-install@v2"
 
-          - name: Install dependencies
-            run: composer install
-
-          - name: Run static type analysis
-            run: vendor/bin/phpstan
-
-          - name: Run test suite
-            run: vendor/bin/phpunit
+            -   run: ${{ matrix.actions.run }}

ecs.php

@@ -2,27 +2,8 @@
 
 declare(strict_types=1);
 
-use PhpCsFixer\Fixer\Import\NoUnusedImportsFixer;
 use Symplify\EasyCodingStandard\Config\ECSConfig;
 
 return ECSConfig::configure()
-    ->withPaths([
-        __DIR__ . '/src',
-        __DIR__ . '/tests',
-    ])
-
-    // add a single rule
-    ->withRules([
-        NoUnusedImportsFixer::class,
-    ])
-
-    // add sets - group of rules
-   // ->withPreparedSets(
-        // arrays: true,
-        // namespaces: true,
-        // spaces: true,
-        // docblocks: true,
-        // comments: true,
-    // )
-
-     ;
+    ->withPaths([__DIR__ . '/src', __DIR__ . '/tests'])
+    ->withPreparedSets(psr12: true);

src/CakePHP/PortedInflector.php

@@ -229,13 +229,13 @@ public static function pluralize($word)
 
         if (!isset(static::$_plural['cacheUninflected']) || !isset(static::$_plural['cacheIrregular'])) {
             static::$_plural['cacheUninflected'] = '(?:' . implode(
-                    '|',
-                    static::$_plural['merged']['uninflected']
-                ) . ')';
+                '|',
+                static::$_plural['merged']['uninflected']
+            ) . ')';
             static::$_plural['cacheIrregular'] = '(?:' . implode(
-                    '|',
-                    array_keys(static::$_plural['merged']['irregular'])
-                ) . ')';
+                '|',
+                array_keys(static::$_plural['merged']['irregular'])
+            ) . ')';
         }
 
         if (preg_match('/(.*?(?:\\b|_))(' . static::$_plural['cacheIrregular'] . ')$/i', $word, $regs)) {
@@ -272,6 +272,6 @@ public static function pluralize($word)
     private static function underscore($camelCasedWord)
     {
         $underscoredWord = preg_replace('/(?<=\\w)([A-Z])/', '_\\1', (string) $camelCasedWord);
-        return  mb_strtolower($underscoredWord);
+        return mb_strtolower($underscoredWord);
     }
 }

src/ClassMethodExtension/ModelMethodExtension.php

@@ -70,7 +70,7 @@ static function (
                 return $methodReflection->getName() === $methodName;
             }
         );
-        if (! $methodReflections) {
+        if (!$methodReflections) {
             throw new Exception('Method not found');
         }
         return reset($methodReflections);

src/ClassPropertyExtension/ClassComponentPropertyExtension.php

@@ -80,7 +80,7 @@ private function getDefinedComponentsAsList(ClassReflection $classReflection): a
         $definedComponents = [];
 
         foreach (array_merge([$classReflection], $classReflection->getParents()) as $class) {
-            if (! $class->hasProperty('components')) {
+            if (!$class->hasProperty('components')) {
                 continue;
             }
 
@@ -89,7 +89,7 @@ private function getDefinedComponentsAsList(ClassReflection $classReflection): a
                 ->getDefaultValueExpression();
 
             if (!$defaultValue instanceof Array_) {
-               continue;
+                continue;
             }
 
             foreach ($defaultValue->items as $item) {

src/ClassPropertyExtension/ShellClassPropertyExtension.php

@@ -4,7 +4,6 @@
 
 namespace PHPStanCakePHP2\ClassPropertyExtension;
 
-
 /**
  * Adds {@link Model}s as properties to {@link Shell}s.
  *

src/ModelBehaviorMethodExtractor.php

@@ -69,7 +69,7 @@ private function filterBehaviorMethods(
         ExtendedMethodReflection $methodReflection
     ): bool {
         return $methodReflection->isPublic()
-            && ! $methodReflection->isStatic()
+            && !$methodReflection->isStatic()
             && array_filter(
                 $methodReflection->getVariants(),
                 [$this, 'filterBehaviorMethodVariants']
@@ -87,7 +87,7 @@ private function filterBehaviorMethodVariants(
         /** @var ParameterReflection|null $firstParameter */
         $firstParameter = array_shift($parameters);
 
-        if (! $firstParameter) {
+        if (!$firstParameter) {
             return false;
         }
 

src/Reflection/ClassReflectionFinder.php

@@ -61,7 +61,7 @@ private function getClassNamesFromPaths(
         $classPaths = [];
         foreach ($paths as $path) {
             $filePaths = glob($path);
-            if (! is_array($filePaths)) {
+            if (!is_array($filePaths)) {
                 throw new Exception(sprintf('glob(%s) caused an error', $path));
             }
             $classPaths = array_merge($classPaths, $filePaths);

tests/ClassPropertyExtension/ClassComponentPropertyExtension/Fixture/existing_component_component.php

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use function PHPStan\Testing\assertType;
 

tests/ClassPropertyExtension/ClassComponentPropertyExtension/Fixture/existing_controller_component.php

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use function PHPStan\Testing\assertType;
 

tests/ClassPropertyExtension/ClassComponentPropertyExtension/Fixture/existing_controller_component_from_parent_controller.php

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use function PHPStan\Testing\assertType;
 

tests/ClassPropertyExtension/ClassComponentPropertyExtension/Fixture/existing_controller_component_with_same_method_name_as_model.php

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use function PHPStan\Testing\assertType;
 

tests/ClassPropertyExtension/ClassComponentPropertyExtension/Fixture/invalid_component_property.php

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use function PHPStan\Testing\assertType;
 

tests/ClassPropertyExtension/ClassModelsPropertyExtension/ClassModelPropertyExtensionsTest.php

@@ -4,6 +4,7 @@
 
 namespace PHPStanCakePHP2\Tests\ClassPropertyExtension\ClassModelsPropertyExtension;
 
+use Iterator;
 use PHPStan\Testing\TypeInferenceTestCase;
 use PHPUnit\Framework\Attributes\DataProvider;
 
@@ -18,10 +19,9 @@ public function test(string $assertType, string $file, ...$args): void
         $this->assertFileAsserts($assertType, $file, ...$args);
     }
 
-    public static function dataFileAsserts(): \Iterator
+    public static function dataFileAsserts(): Iterator
     {
         yield from self::gatherAssertTypes(__DIR__ . '/Fixture/core_model_behavior.php');
-        yield from self::gatherAssertTypes(__DIR__ . '/Fixture/custom_model_behavior.php');
         yield from self::gatherAssertTypes(__DIR__ . '/Fixture/invalid_model_property.php');
         yield from self::gatherAssertTypes(__DIR__ . '/Fixture/existing_model_model.php');
 

tests/ClassPropertyExtension/ClassModelsPropertyExtension/Fixture/core_model_behavior.php

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use function PHPStan\Testing\assertType;
 

tests/ClassPropertyExtension/ClassModelsPropertyExtension/Fixture/existing_controller_model.php

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use function PHPStan\Testing\assertType;
 

tests/ClassPropertyExtension/ClassModelsPropertyExtension/Fixture/existing_model_model.php

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use function PHPStan\Testing\assertType;
 

tests/ClassPropertyExtension/ClassModelsPropertyExtension/Fixture/invalid_controller_property.php

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use function PHPStan\Testing\assertType;
 

tests/ClassPropertyExtension/ClassModelsPropertyExtension/Fixture/invalid_model_property.php

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use function PHPStan\Testing\assertType;
 

tests/ClassPropertyExtension/ShellClassPropertyExtension/Fixture/existing_shell_model.php

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use function PHPStan\Testing\assertType;
 

tests/ClassPropertyExtension/ShellClassPropertyExtension/Fixture/existing_shell_task.php

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use function PHPStan\Testing\assertType;
 

tests/ClassPropertyExtension/ShellClassPropertyExtension/Fixture/invalid_shell_property.php

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use function PHPStan\Testing\assertType;
 

tests/ClassPropertyExtension/ShellClassPropertyExtension/ShellClassPropertyExtensionTest.php

@@ -22,8 +22,8 @@ public function test(string $assertType, string $file, ...$args): void
     public static function dataFileAsserts(): \Iterator
     {
         yield from self::gatherAssertTypes(__DIR__ . '/Fixture/existing_shell_model.php');
-//        yield from self::gatherAssertTypes(__DIR__ . '/Fixture/existing_shell_task.php');
-//        yield from self::gatherAssertTypes(__DIR__ . '/Fixture/invalid_shell_property.php');
+        //        yield from self::gatherAssertTypes(__DIR__ . '/Fixture/existing_shell_task.php');
+        //        yield from self::gatherAssertTypes(__DIR__ . '/Fixture/invalid_shell_property.php');
     }
 
     /**

tests/Source/Model/Behavior/BasicBehavior.php

@@ -1,6 +1,7 @@
 <?php
 
 namespace PHPStanCakePHP2\Tests\Source\Model\Behavior;
+
 use Model;
 use ModelBehavior;
 

tests/Source/Model/SameAsModel.php

@@ -1,6 +1,7 @@
 <?php
 
 namespace PHPStanCakePHP2\Tests\Source\Model;
+
 use Model;
 
 class SameAsModel extends Model