Return floating_preview window id #4828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idbrii
force-pushed
the
floatingpreview
branch
from
6c859f5
to
8b38cb0
Compare
Make ale#floating_preview#Show more similar to popup_create and return the id of the window so it's easy to set the filetype of the resulting buffer. Update test stub version of Show() to return a win id (the current window since it's not actually creating a window). Test * both tests still pass
idbrii
force-pushed
the
floatingpreview
branch
from
8b38cb0
to
a1fe863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
ale#floating_preview#Showmore similar topopup_createand return the id of the window so it's easy to set the filetype of the resulting buffer.This doesn't affect any other ale code. It just makes it easier to use ALE's library function in my vim config.