Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use with keyword for import attributes #4141

Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix: use with keyword for import attributes #4141

merged 2 commits into from
Jan 10, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jan 10, 2024

@iuioiua iuioiua requested a review from kt3k as a code owner January 10, 2024 09:45
@github-actions github-actions bot added the http label Jan 10, 2024
@iuioiua iuioiua changed the title refactor: use with keyword for import attributes fix: use with keyword for import attributes Jan 10, 2024
@iuioiua iuioiua enabled auto-merge (squash) January 10, 2024 10:05
kt3k
kt3k approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@iuioiua iuioiua merged commit 668856c into main Jan 10, 2024
12 checks passed
@iuioiua iuioiua deleted the with branch January 10, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
console html http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k