Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent update doc title from partial if not present #2244

Merged
merged 2 commits into from
Jan 12, 2024
Merged

fix: Prevent update doc title from partial if not present #2244

merged 2 commits into from
Jan 12, 2024

Conversation

igorbrasileiro
Copy link
Contributor

fixes #2243

marvinhagemeister
marvinhagemeister reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's a good catch! Let's add a test case for this and then it's ready to land 👍

@igorbrasileiro
Copy link
Contributor Author

Oh that's a good catch! Let's add a test case for this and then it's ready to land 👍

Do you have a suggestion of test file to add this or i can create a new one for this case?

marvinhagemeister
marvinhagemeister approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, those tests look great 👍

@marvinhagemeister marvinhagemeister merged commit e7bf6ac into denoland:main Jan 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Partials] Losing title after partial run
2 participants
@igorbrasileiro @marvinhagemeister