Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve no-console and no-window rule analysis #1235

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix: improve no-console and no-window rule analysis #1235

merged 1 commit into from
Jan 24, 2024

Conversation

littledivy
Copy link
Member

Fixes #1232

bartlomieju
bartlomieju approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

@littledivy littledivy merged commit 6e12763 into denoland:main Jan 24, 2024
6 checks passed
@littledivy littledivy deleted the fix_no_console_no_window branch January 24, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-console and no-window warn on object property names
2 participants
@littledivy @bartlomieju