Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl Eq on ConfigFileJson #30

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

nayeemrmn
Copy link
Collaborator

I might be refactoring how deno/didChangeDenoConfiguration works so it's more sensible, needs this.

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's actually this simple, because many config files, even if they are textually different, are semantically identical. Take for example exclude: null vs exclude: []

@nayeemrmn
Copy link
Collaborator Author

Currently we just do it on file changes, that behaviour is fine. I just noticed this was a missing impl considering it's a basic wrapper of serde's Value, and you'd have to serialize it to a string to compare. It's on ConfigFileJson rather than ConfigFile so there's no confusion.

@lucacasonato
Copy link
Member

Ah ok

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit 945ef2a into denoland:main Jan 17, 2024
3 checks passed
@nayeemrmn nayeemrmn deleted the config-file-json-eq branch January 17, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants