feat: support "compilerOptions.rootDirs" #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Jan 28, 2025
dsherret
approved these changes
Jan 28, 2025
| pub struct WorkspaceResolver { | ||
| struct CompilerOptionsRootDirsResolver<TSys: FsMetadata> { | ||
| root_dirs_from_root: Vec<Url>, | ||
| root_dirs_by_member: BTreeMap<Url, Option<Vec<Url>>>, |
There was a problem hiding this comment.
Nitpick: Maybe we should just not have a member entry when its value is None? Or do we need to represent this as None? (if not, it would slightly reduce the number of comparisons)
There was a problem hiding this comment.
It makes a difference if you have members within members, to prevent cascading inheritance between them in some cases.
(We have cascading inheritance for import maps as a side-effect of using scopes but not for other fields.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream: denoland/deno#27844.