-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add unstable
field
#14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as "Request changes" cause we need a bit of bike-shedding on the name. Otherwise LGTM
src/lib.rs
Outdated
@@ -454,6 +454,8 @@ pub struct ConfigFileJson { | |||
pub workspace: bool, | |||
#[serde(default)] | |||
pub members: Vec<String>, | |||
#[serde(default)] | |||
pub features: Vec<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe unstable
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We'd like to read feature flag from deno.json(c). This PR adds reading of
features
unstable
field.Related: denoland/deno#20779