Apply suggestions from code review

Co-authored-by: David Sherret <[email protected]>
denoland · Nov 4, 2024 · 404a7a6 · 404a7a6
1 parent fbef272
commit 404a7a6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/workspace/mod.rs b/src/workspace/mod.rs
@@ -141,8 +141,8 @@ pub enum WorkspaceDiagnosticKind {
     previous: bool,
     suggestion: NodeModulesDirMode,
   },
-  #[error("invalid workspace member \"{name}\".")]
-  InvalidMember { name: String },
+  #[error("Invalid workspace member name \"{name}\". Ensure the name is in the format '@scope/name'.")]
+  InvalidMemberName { name: String },
 }
 
 #[derive(Debug, Error, Clone, PartialEq, Eq)]
@@ -681,7 +681,7 @@ impl Workspace {
         if !is_valid_jsr_pkg_name(name) {
           diagnostics.push(WorkspaceDiagnostic {
             config_url: config.specifier.clone(),
-            kind: WorkspaceDiagnosticKind::InvalidMember { name: name.clone() },
+            kind: WorkspaceDiagnosticKind::InvalidMemberName { name: name.clone() },
           });
         }
       }

diff --git a/src/workspace/resolver.rs b/src/workspace/resolver.rs
@@ -1530,7 +1530,7 @@ mod test {
       .first()
       .unwrap()
       .to_string()
-      .starts_with(r#"invalid workspace member "@deno-test/libs/math"."#));
+      .starts_with(r#"Invalid workspace member name "@deno-test/libs/math"."#));
   }
 
   fn create_resolver(workspace_dir: &WorkspaceDirectory) -> WorkspaceResolver {